Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render dots in meeting subheader #14259

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Render dots in meeting subheader #14259

merged 2 commits into from
Nov 29, 2023

Conversation

oliverguenther
Copy link
Member

@oliverguenther oliverguenther commented Nov 28, 2023 •
edited
Loading

HDinger
HDinger requested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@HDinger HDinger left a comment •
edited by oliverguenther
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When editing the title, the dots are missing as well
Bildschirmfoto 2023-11-28 um 14 23 34
  • When the updated_at timestamp is long ago (so that a date is shown), there are two dots shown (not sure if want to do anything about that or just accept that)
Bildschirmfoto 2023-11-28 um 14 24 53
  • Due to the dot being outside of the RelativeTime component, it has a different color.
Bildschirmfoto 2023-11-28 um 14 24 53
  • Not related to your PR, but maybe you can fix it in the same run: The time label is only partly translated:
Bildschirmfoto 2023-11-28 um 14 28 58

@oliverguenther oliverguenther force-pushed the fix/meeting-punctutation branch from cc8fe31 to 570d765 Compare November 29, 2023 10:48
HDinger
HDinger approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the extra work @oliverguenther

@oliverguenther oliverguenther merged commit 695b736 into dev Nov 29, 2023
8 of 9 checks passed
@oliverguenther oliverguenther deleted the fix/meeting-punctutation branch November 29, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HDinger HDinger HDinger approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverguenther @HDinger